ext/gd: pack imageloadfont short-read test in native byte order#22416
Open
iliaal wants to merge 1 commit into
Open
ext/gd: pack imageloadfont short-read test in native byte order#22416iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
imageloadfont_short_read packed the font header with pack('V4', ...)
(little-endian), but imageloadfont() reads the header as native-endian
ints. On big-endian hosts (PPC64 nightly) the byte-swapped values
overflow the INT_MAX guard before the FLIPWORD fallback runs, so the
font is rejected and the test fails. Pack the fields with 'i' to keep
the header valid regardless of host endianness.
Member
|
@iliaal I would recommend to enable CI for PPC64 (look at the labels) since this is where the issue was from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imageloadfont_short_read test packed the font header with
pack('V4', ...)(little-endian), butimageloadfont()reads it as native-endian ints, so on big-endian hosts the byte-swapped values trip the INT_MAX overflow guard before the FLIPWORD fallback and the font is rejected. Packing withpack('i4', ...)keeps the header valid on both, fixing the PPC64 nightly failure.